diff --git a/lib/HistorySearch.cpp b/lib/HistorySearch.cpp index 41c514f..33c6f4e 100644 --- a/lib/HistorySearch.cpp +++ b/lib/HistorySearch.cpp @@ -24,7 +24,7 @@ #include "Emulation.h" #include "HistorySearch.h" -HistorySearch::HistorySearch(EmulationPtr emulation, QRegExp regExp, +HistorySearch::HistorySearch(EmulationPtr emulation, const QRegExp& regExp, bool forwards, int startColumn, int startLine, QObject* parent) : QObject(parent), diff --git a/lib/HistorySearch.h b/lib/HistorySearch.h index 80b35db..ad5ac87 100644 --- a/lib/HistorySearch.h +++ b/lib/HistorySearch.h @@ -38,7 +38,7 @@ class HistorySearch : public QObject Q_OBJECT public: - explicit HistorySearch(EmulationPtr emulation, QRegExp regExp, bool forwards, + explicit HistorySearch(EmulationPtr emulation, const QRegExp& regExp, bool forwards, int startColumn, int startLine, QObject* parent); ~HistorySearch() override; diff --git a/lib/TerminalDisplay.cpp b/lib/TerminalDisplay.cpp index 79fd16b..688afe0 100644 --- a/lib/TerminalDisplay.cpp +++ b/lib/TerminalDisplay.cpp @@ -711,7 +711,7 @@ void TerminalDisplay::setOpacity(qreal opacity) _blendColor = color.rgba(); } -void TerminalDisplay::setBackgroundImage(QString backgroundImage) +void TerminalDisplay::setBackgroundImage(const QString& backgroundImage) { if (!backgroundImage.isEmpty()) { diff --git a/lib/TerminalDisplay.h b/lib/TerminalDisplay.h index 83cd3e7..9c47c17 100644 --- a/lib/TerminalDisplay.h +++ b/lib/TerminalDisplay.h @@ -104,7 +104,7 @@ public: void setOpacity(qreal opacity); /** Sets the background image of the terminal display. */ - void setBackgroundImage(QString backgroundImage); + void setBackgroundImage(const QString& backgroundImage); /** * Specifies whether the terminal display has a vertical scroll bar, and if so whether it diff --git a/lib/qtermwidget.cpp b/lib/qtermwidget.cpp index f7a8455..c50472d 100644 --- a/lib/qtermwidget.cpp +++ b/lib/qtermwidget.cpp @@ -369,7 +369,7 @@ void QTermWidget::setTerminalOpacity(qreal level) m_impl->m_terminalDisplay->setOpacity(level); } -void QTermWidget::setTerminalBackgroundImage(QString backgroundImage) +void QTermWidget::setTerminalBackgroundImage(const QString& backgroundImage) { m_impl->m_terminalDisplay->setBackgroundImage(backgroundImage); } diff --git a/lib/qtermwidget.h b/lib/qtermwidget.h index 672e745..8bc2f09 100644 --- a/lib/qtermwidget.h +++ b/lib/qtermwidget.h @@ -87,7 +87,7 @@ public: void setTerminalFont(const QFont & font); QFont getTerminalFont(); void setTerminalOpacity(qreal level); - void setTerminalBackgroundImage(QString backgroundImage); + void setTerminalBackgroundImage(const QString& backgroundImage); //environment void setEnvironment(const QStringList & environment);