From ae71042e0d3b352c5cbf34b9ab635aea717de4df Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lu=C3=ADs=20Pereira?= Date: Tue, 14 Jan 2020 19:02:06 +0000 Subject: [PATCH] Prevent a c++11 range-loop might detach Qt container Just make it const. --- lib/ColorScheme.cpp | 4 ++-- lib/qtermwidget.cpp | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/ColorScheme.cpp b/lib/ColorScheme.cpp index d85c52c..2ccb29a 100644 --- a/lib/ColorScheme.cpp +++ b/lib/ColorScheme.cpp @@ -730,7 +730,7 @@ QList ColorSchemeManager::listKDE3ColorSchemes() QStringList filters; filters << QLatin1String("*.schema"); dir.setNameFilters(filters); - QStringList list = dir.entryList(filters); + const QStringList list = dir.entryList(filters); for (const QString &i : list) ret << dname + QLatin1Char('/') + i; } @@ -750,7 +750,7 @@ QList ColorSchemeManager::listColorSchemes() QStringList filters; filters << QLatin1String("*.colorscheme"); dir.setNameFilters(filters); - QStringList list = dir.entryList(filters); + const QStringList list = dir.entryList(filters); for (const QString &i : list) ret << dname + QLatin1Char('/') + i; } diff --git a/lib/qtermwidget.cpp b/lib/qtermwidget.cpp index 9a9c41d..e88891e 100644 --- a/lib/qtermwidget.cpp +++ b/lib/qtermwidget.cpp @@ -276,7 +276,7 @@ void QTermWidget::init(int startnow) m_translator = new QTranslator(this); - for (const QString& dir : dirs) { + for (const QString& dir : qAsConst(dirs)) { //qDebug() << "Trying to load translation file from dir" << dir; if (m_translator->load(QLocale::system(), QLatin1String("qtermwidget"), QLatin1String(QLatin1String("_")), dir)) { qApp->installTranslator(m_translator);