Commit Graph

16 Commits

Author SHA1 Message Date
Chih-Hsuan Yen 9a45a56f04 Improve "Undecodable sequence" warnings
Using Qt logging utilities instead of printf so that those warnings
can be enabled/disabled. Those warnings are disabled by default. To
enable them, use QT_LOGGING_RULES="qtermwidget.debug=true".

Also improve the formatting. An example warning:

Undecodable sequence: "\u001B[22;0;0t"

Closes https://github.com/lxqt/qterminal/issues/640
2020-12-26 16:54:52 +08:00
Luís Pereira f16e4495b4 Don't search application dir for keyboard and scheme data
QCoreApplication::applicationDirPath() is the right place to store
application data.
Exception is MacOs, where it can make sense.
2020-06-09 12:30:51 +08:00
Luís Pereira 60836291f6 Use qAsConst
It's available now and much easier to read.
2020-06-09 12:30:51 +08:00
Vadim Zabermakh 0ad6fbfa86 Macro Q_WS_MAC renamed to Q_OS_MAC. Added QLatin1String in string concatenations on MacOS 2019-11-24 16:12:40 +01:00
Tsu Jan e9d6b36624 Removed some debug outputs
Users don't need to seem them. If an info is really important, it should be shown in a message box, IMHO.
2019-10-21 21:08:54 +02:00
Chih-Hsuan Yen b8df480d60 Drop the ability to bundle kb-layouts and colorschemes 2018-09-30 01:25:44 +02:00
Luís Pereira c6880070e9 Don't use automatic string conversions
* Disables automatic conversions from 8-bit strings (char *) to unicode
  QStrings.
* Disables automatic conversion from QString to 8-bit strings (char *).
* Disables automatic conversions from QByteArray to const char * or const
  void *.
* Disables automatic conversions from QString (or char *) to QUrl.
* Use QStringBuilder for more efficient string creation.

It make us aware of string and encoding conversions.
2018-08-05 22:09:57 +08:00
Luís Pereira 3ce71a3650 Fixes (#122)
* Prevent a possible C++11 range for detach

The solution with Qt>=5.7 is to use the qAsConst() macro.
But the qAsConst macro is just a const_cast to const T&.

* Don't call QByteArray::operator[]() on temporary

Just use the QByteArray::at().

* Adds missing reference in foreach

That's an non non trivial type (QString), using a reference as no drawbacks
and it performs better.

* Use QStringList::constFirst()

Drop QStringList::first(). It's faster and we might avoid detaching a
temporary.

* Don't call QList::operator[]() on temporary objects

It's not what we want. The at operator and QList::value() do the job in the
right way.

* Stops allocating an unneeded temporary container

We were allocating an temporary container (_entries.values(keyCode)) which
implies an extra iteration also.
Now we don't use any temporary container and only perform one iteration.
2017-04-22 11:55:16 +02:00
Igor 534a86a00a Make addCustomColorSchemeDir() static and check for duplicates 2016-05-26 14:50:14 +03:00
Igor 405ad67bdc Address review comments 2016-05-25 17:17:46 +03:00
Igor ad59d1dc5e Allow app to add custom color sheme locations 2016-05-25 11:15:14 +03:00
Petr Vanek d6ceb5ae00 build simplified: qtermwidget is versioned (libqtermwidget4 for Qt4, 5 for Qt5...). Better cmake support. 2014-04-11 20:50:22 +02:00
Adam Treat 330c8e4402 Add resource files and the appropriate paths to enable bundling of color schemes
and keyboard layouts into the actual executable.
2012-01-28 13:45:14 -05:00
Adam Treat b306ff7192 Add a define which will be used to bundle the color schemes and keyboard layouts
as resource files with the executable itself instead of putting them on disk.
2012-01-28 13:44:57 -05:00
Petr Vanek 2be1dbb707 improved sample app for testing 2011-09-25 15:29:15 +02:00
Petr Vanek 6ad5d7070a merge changes from the experimental "bundle" repository 2011-06-22 13:12:21 +02:00